Ask / Submit
3

updates vs patches

asked 2016-10-21 09:36:16 +0300

danfin gravatar image

hi folks, i've got several patches intalled. I like OS is maintained well. But I find it annoying that after OS updates patches need be updated aswell. As I happen to find my patches add practical functionality to the OS. Why can't that get updated and leave those patches running?

edit retag flag offensive close delete

Comments

6

Because the patches do unmaintained stuff. The patches change files which are held in upstream packages of the distribution. If these files are changed (e. g. for other improvements) the patches will not work anymore. You patch on your own risk.

cy8aer ( 2016-10-21 10:29:52 +0300 )edit

Better would be: Discussion Patch-specialists/Community <-> Jolla which patches would make sense for upstream.

cy8aer ( 2016-10-21 10:32:22 +0300 )edit

Discussion Patch-specialists/Community sounds a good idea. (how to set those tags, then? sorry I'm a dummy)

danfin ( 2016-10-21 10:55:21 +0300 )edit
2

Patches is a modification to existing code. There is no magic in patches.

coderus ( 2016-10-21 11:57:21 +0300 )edit
1

Perhaps you should study the anatomy of a 'patch' and also how Patchmanager works with files, then learn how to author a patch and then you will see the answer to your own question and why things are currently the way they are.....annoying?, you should try being a maintainer! :D

Edz ( 2016-10-21 18:40:22 +0300 )edit

2 Answers

Sort by » oldest newest most voted
15

answered 2016-10-21 11:49:05 +0300

PatsJolla gravatar image

I would like a different approach:

Since we have so many very good Patches that make the usability much better we should consider integrating them as setting options in SFOS.

A vote which patches should be integrated into SFOS first, could help to get most used ones into the SFOS standard. On a long term view this will make SFOS more configurable and more user friendly in my eyes.

edit flag offensive delete publish link more

Comments

@PatsJolla, could you please create a new post, so we can post answers for each patch and getting votes for it.

poddl ( 2016-10-21 15:36:36 +0300 )edit

@poddl: Sure I will do

PatsJolla ( 2016-10-21 17:00:34 +0300 )edit

So the new survey thread has been started: https://together.jolla.com/question/149031/survey-which-patches-would-make-sense-for-upstream/

PatsJolla ( 2016-10-21 17:11:44 +0300 )edit
5

answered 2016-10-21 12:56:00 +0300

nthn gravatar image

An example to show how patches work, and why they can't just stay active across Sailfish updates: let's say the original code in Sailfish is a sentence "There is a mouse in my house."

There is a patch that changes this sentence to "There is no mouse in my house, but there is a rat.", which changes the 3rd word of the sentence to "no", and adds ", but there is a rat" after the 7th word of the sentence and before the full stop (the 8th 'word' of the sentence).

A Sailfish update changes the sentence to say "There are mice in my house."

Now the patch, which changes the 3rd word and adds something in between 7 and 8, changes the sentence to "There are no in my house., but there is a rat"

As you can see, even though there was only a very small change in the original sentence, the new sentence is not correct anymore. Now imagine every word of the sentence is an instruction of some kind, and you'll see this could lead to a lot of trouble.

edit flag offensive delete publish link more

Comments

in most cases a smoke gun or a pack of rodent poison will help. Though I believe in animal's right of life.

danfin ( 2016-10-21 13:55:00 +0300 )edit

Don't focus on the example, you've missed the answer to your question.

Sthocs ( 2016-10-21 15:09:33 +0300 )edit
Login/Signup to Answer

Question tools

Follow
2 followers

Stats

Asked: 2016-10-21 09:36:16 +0300

Seen: 497 times

Last updated: Oct 21 '16