asked 2018-02-20 15:50:53 +0300
It would be useful to be able to rotate documents, especially for scans of book pages, because those often consist of two pages in one scan, and simply rotating the device means you need to scroll in unusual directions.
answered 2018-03-16 15:24:26 +0300
I'm proposition an implementation for this request. The backend part is working well, at least from my quick testing. Page can be rotated and selection, links and annotations are still working as expected. Rotation status of document is saved when leaving a document, so coming back to it will show it up in the right orientation.
But, I'm not satisfied at all with what I've done in the UI. The action is presented in the toolbar, which makes it too full and rotation is not something used very often. I've tried to make it work via a pinch to rotate gesture, but it's not confortable for the fingers IMHO, and it interferes all the time with the pinch to zoom feature.
This illustrates the toolbar in portrait mode with all actions (the back arrow is because I've tapped on an internal link in the document).
I would be happy to implement any clever idea where to put this.
Edit 2018-03-19: I've tried the proposition of @ApB to add a push up menu with the rotate action. It's quite nice indeed.
@nthn: thank you. I'm waiting for webhook to be fixed in Mer to have a testing package built in OBS so every one can try.
The problem with the page index (I put it there as a pull down menu) is that the effect is not visible and we never know if we turned it properly, needing to go back to the index page again if we turned it wrongly.
The problem with the pull down menu in the share drawer is that this pull down menu is not accessible from the PDF document because it is generic for all documents, PDF but also Office documents. I'm not eager to break this genericity specifically for PDFs.
Damien Caliste ( 2018-03-16 22:53:08 +0300 )editAsked: 2018-02-20 15:50:53 +0300
Seen: 299 times
Last updated: Mar 19 '18
As Jolla's "Documents" app rotates nicely when the screen orientation changes (at least on my Jolla 1 phones with the Patches "Free rotation" (by alina from OpenRepos) or "Allow any orientation" (by coderus from Patchmanager's web-catalog) installed), supposedly your feature suggestion is just about a setting for Jolla's "Documents" app to switch the scroll direction from vertically to horizontally (as some "Documents"- / PDF-viewers for Android allow for), right?
olf ( 2018-02-20 22:26:06 +0300 )editSimply changing the scroll direction wouldn't help with all of the border gestures in different places than they usually are (and just the entire interface being in a different place in general). My feature request is for rotating the pages, a simple function available in just about any PDF reader. I'll change the title so it's clear 'documents' doesn't refer to the 'Documents' app, but to actual documents opened in the app.
nthn ( 2018-02-20 23:21:39 +0300 )editSo this is meant solely as a workaround for incorrectly oriented (i.e. IMO "broken") PDFs?
olf ( 2018-02-20 23:45:10 +0300 )edit@olf You don't always have control of how the PDFs you need to read have been created, and every now and then I need to rotate a document I got in my hands. In a perfect world it would of course not be needed, but as we all know, the world's not perfect. All decent PDF viewers for desktop use that I know of have this functionality.
luen ( 2018-02-21 02:42:58 +0300 )editI've opened an issue for Sailfish office in Github. I support your proposition and will try to implement it in the coming weeks. Feel free to comment in Github issue also.
Damien Caliste ( 2018-02-21 11:34:37 +0300 )edit