[Regression] Unable to set peak times for accounts

Tracked by Jolla (In release)

asked 2018-10-31 23:55:33 +0300

Mohjive

8581 ●166 ●226 ●250

http://www.y3k.se/

updated 2018-11-09 01:00:57 +0300

saturn
1827 ●19 ●32 ●37

It's not possible to modify the peak time for the sync schedule for a new e-mail account in Sailfish X 3.0. When I modify it using the dial and then select "accept" the time is no longer shown in the account view and the entry is no longer clickable to re-select a new time. If I return to the account list and then go back edit the account again the default values are there again (09:00/17:00).

I have the same issues with Google and Exchange accounts.

[Edit:} Issue remains with 3.0.0.8 public release

edit retag flag offensive close delete

Comments

I noticed the same thing when re-adding my mail accounts after the update. I restored my backup from the previous SFOS version (since adding my Office365 account from work seems like impossible). After that, the Exchange account worked again, but all IMAP accounts failed to connect, so I had to remove and then re-add them. That's when I noticed this issue. Additionally, changes made to other settings (e.g. (de)selecting the peak days or changing the name etc) are not saved. Since I haven't changed my accounts for a long time, I can't say if this issue started with 3.0.

ghling ( 2018-11-03 09:48:19 +0300 )edit

1

Can confirm with Xperia X and Exchange.

when i try to set the peak time, the setting is accepted and then the time disappears from the GUI.

saturn ( 2018-11-03 22:54:26 +0300 )edit

Maybe we can narrow down the issue: Are accounts affected that you already created with an old SFOS version? Or have you created them with SFOS 3 (like in my case)?

ghling ( 2018-11-05 09:00:59 +0300 )edit

@ghling in my case it is newly created exchange account. In the release notes it was mentioned to delete and recreate the accounts since the new MfE libraries.

also, there was the same happened in an older release as discussed here: https://together.jolla.com/question/500/bug-e-mail-synchronization-does-not-work-as-configured/ Maybe not relevant, but maybe worth mentioning.

saturn ( 2018-11-05 10:01:36 +0300 )edit

@ghling: it affects both new and old accounts. I ran into it when I re-added my gmail and exchange accounts after upgrading to SfOS 3, but it's also present when I try to change peak times for my imap account which is since before the upgrade.

Mohjive ( 2018-11-05 11:40:58 +0300 )edit

7

answered 2018-11-15 10:05:01 +0300

Damien Caliste
6535 ●105 ●139 ●161

https://github.com/dcalis...

The regression was introduced by mistake when migrating the code to the new animatorPush() function to open new pages on stack in 3.0.0. This new method makes the app more responsive in case the page load time becomes noticable. @jpetrell accepted the following patch yesterday, so correction should arrive in a later version.

For reference, here is the patch:

@@ -86,7 +86,7 @@ Column {
                                              })
             obj.pageCompleted.connect(function(dialog) {
                 dialog.accepted.connect(function() {
-                    root.peakStartTime = obj.time
+                    root.peakStartTime = dialog.time
                     root._updateSchedule()
                 })
             })
@@ -105,7 +105,7 @@ Column {
                                              })
             obj.pageCompleted.connect(function(dialog) {
                 dialog.accepted.connect(function() {
-                    root.peakEndTime = obj.time
+                    root.peakEndTime = dialog.time
                     root._updateSchedule()
                 })
             })

It should be applied on /usr/lib/qt5/qml/com/jolla/settings/accounts/PeakSyncOptions.qml.

edit flag offensive delete publish link

Comments

Confirmed the patch works wonders on Jolla 1 - 3.0.0.8. Thanks!!!!

lakeboy ( 2018-11-15 12:01:14 +0300 )edit

Great, patched the file, now it works again. That's the amazing thing when having full root access via shell to your system. Thank you for pointing out the patch.

ghling ( 2018-11-18 10:33:39 +0300 )edit

3

answered 2018-11-15 15:52:28 +0300

jiit

2678 ●32 ●58 ●59

admin

This issue is now fixed and the fix will be available in the upcoming releases. Apologies for the trouble so far.

edit flag offensive delete publish link

Comments

It works when re-adding the account. Not with an existing account. I think this question can be closed if others experience the same.

BonoNL ( 2019-05-09 10:17:53 +0300 )edit

[Regression] Unable to set peak times for accounts

Comments

2 Answers

Comments

Comments

Question tools

Stats

Related questions

[Regression] Unable to set peak times for accounts

Comments

2 Answers

Comments

Comments

Question tools

Public thread

Stats

Related questions