[Regression] Status Bar container overlaps maximized application in Partner Space

asked 2018-11-04 03:28:17 +0300

g7 gravatar image

updated 2018-11-10 12:49:51 +0300

Update: still not fixed on 3.0.0.8

After upgrading to 3.0.0.5 maximized applications inside Partner Spaces have their topmost part touch-blocked by the status bar container (the status bar itself isn't visible, but its container overlaps the application and thus touch events go there instead of the application).

How to reproduce

Step 0: Put an application inside a Partner Space

For this example I've used the CSD application:

dconf write /desktop/lipstick-jolla-home/partnerspace/applications "['/usr/share/applications/csd.desktop']"

Step 1: Swipe to the Partner Space, wait for the application to load, tap on the application so that it gets maximized

Step 2: Try to Accept / Dismiss the CSD Disclaimer by tapping on the "Accept / Cancel" dialog buttons

How to fix

This patch should do the trick:

Index: /usr/share/lipstick-jolla-home-qt5/layers/HomeLayer.qml
===================================================================
--- .orig/usr/share/lipstick-jolla-home-qt5/layers/HomeLayer.qml
+++ /usr/share/lipstick-jolla-home-qt5/layers/HomeLayer.qml
@@ -22,6 +22,7 @@ Pannable {

     readonly property Item window: currentItem.window
     readonly property bool active: currentItem.active
+    readonly property bool partnerSpaceMaximized: currentItem && currentItem.objectName == "partnerLayer" && currentItem.maximized
     readonly property bool wallpaperVisible: visible && !currentItem.opaque

     property PannableLayer lastActiveLayer
@@ -170,7 +171,7 @@ Pannable {
         height: rotation % 180 == 0
                     ? Lipstick.compositor.height
                     : Lipstick.compositor.width
-        z: active ? 0 : -1000
+        z: (active && !partnerSpaceMaximized) ? 0 : -1000

         StatusBar {
             id: statusBar
Index: /usr/share/lipstick-jolla-home-qt5/layers/PartnerLayer.qml
===================================================================
--- .orig/usr/share/lipstick-jolla-home-qt5/layers/PartnerLayer.qml
+++ /usr/share/lipstick-jolla-home-qt5/layers/PartnerLayer.qml
@@ -38,6 +38,8 @@ PannableLayer {
                 && (!partnerParent.window || windowFadeIn.running)
     property bool _cacheInvalidated

+    objectName: "partnerLayer"
+
     function start() {
         if (launcherItem && !launcherItem.isLaunching) {
             if (launcherActive) {
edit retag flag offensive close delete