Allow top menu shortcuts toggling on locked device

asked 2018-11-14 14:07:17 +0300

naytsyrhc gravatar image

updated 2019-01-12 03:38:34 +0300

rozgwi gravatar image

I just encountered a maybe new "feature" introduced with 3.0.0.8 opposed to how it seemed to work with 3.0.0.5 and how I was able to patch it on SFOS2.

Description:

  • Device is locked and I open the lock screen. I use a swipe from top edge and the top menu opens. I press a toggle (e.g. flashlight or vpn).

Expected behaviour:

  • Toggle toggles (either on or off, depending on current state).

Actual behaviour:

  • For flashlight toggle this worked on SFOS2 and 3.0.0.5 and also on 3.0.0.8.
  • For e.g. VPN or Wifi toggle this does not work anymore on 3.0.0.8 (but did with patched SFOS2 and on 3.0.0.5)

So my question now is: did you, Jolla, change this behaviour for e.g. security reasons or is that a bug in 3.0.0.8. I'd like to have the ability to still toggle Wifi/Bluetooth/VPN without the need to unlock my phone first. I however expect and accept that any other actions (like long-pressing toggles) should not be accessible of course.

Update for 3.0.1

The behaviour is now slightly different and better than before and more consistent. I'd still be happy to have that behaviour configurable. I want to start VPN without unlocking device or enable/disable Wifi without unlocking. So this question still persists: Do you have plans to make this configurable?

edit retag flag offensive close delete

Comments

1

It is a feature, not a bug – it's a restricted access mode. But the same as you, I prefer them to be accessible, so there should be an option. For now there's a patch for it.

Alen ( 2018-11-18 19:54:32 +0300 )edit

As a workaround you can set the value on /usr/share/lipstick-jolla-home-qt5/topmenu/FavoriteSettingsDelegate.qml, line 61, to false

Alen ( 2018-11-18 20:03:39 +0300 )edit

thx for the hint.

naytsyrhc ( 2018-11-18 23:12:10 +0300 )edit

@Alen unfortunately your patch doesn't work with enhanced notfication preview patch. Any chance to get them to work with each other?

naytsyrhc ( 2018-11-19 02:04:16 +0300 )edit

@naytsyrhc I know, but I'm afraid there's no way because that patch removes a lot of lines and writes them from scratch. You can change the diff file and remove the lines related to NotificationPreview. Or just ignore my patch and follow the hint above.

Alen ( 2018-11-19 02:39:51 +0300 )edit