Documents: Misaligned toolbar on Xperia X [closed]

Documents: Misaligned toolbar on Xperia X [released]

Tracked by Jolla (In progress)

asked 2019-08-28 16:13:53 +0300

rozgwi
4618 ●49 ●77 ●79

updated 2019-12-15 21:14:23 +0300

fixed in 3.2.0 thanks to @Damien Caliste

The toolbar of Documents is misaligned/too compact. The icons look a bit off.

The icons are squeezed together instead of being distributed evenly and the font of the page indicator is very small

Especially the page indicator used to be right aligned and bigger which I find easier to use.
When searching, the progress bar doesn't take the full height of the toolbar

The question has been closed for the following reason "released in a software update" by rozgwi
close date 2019-12-15 21:12:58.782908

Comments

Damien Caliste*:
Since you seem to be working on Documents right now, can you have a look?

* how the heck does one mention a user with a space in his name?

rozgwi ( 2019-08-28 16:15:25 +0300 )edit

answered 2019-08-28 17:11:20 +0300

Damien Caliste
6535 ●105 ●139 ●161

https://github.com/dcalis...

updated 2019-08-28 17:13:33 +0300

Hello @rozgwi, thank you for reporting these issues. For the second point, I'm submitting a merge request in Github because it is clearly a mistake.

For the first point, though, I think it was chosen like that by design, I mean to have icon buttons of a restricted width, maybe to avoid awkward layout on landscape. This should be discussed with @Joona Petrell who implemented the new design. Maybe adding a bit more spacing on fixed width button may do the trick of being nice on landscape and thumb friendly on portrait.

About the page indicator label size, I need to test with document with hundred of pages, because currently the width is hardcoded to Theme.itemSizeSmall (which depends itself on DPI of device though) and the label font size will shrink to accommodate.

edit flag offensive delete publish link

Comments

Thanks Damien! I suspected the button arrangement was on purpose.

If it helps I can provide you with a screenshot of the page indicator for a large document (400+ pages)

rozgwi ( 2019-08-28 19:15:52 +0300 )edit

@rozgwi, thanks, I've got some with more than 100 pages indeed. It's looking very small in that case and I'm proposing to expand it a bit: https://github.com/sailfishos/sailfish-office/pull/139

Damien Caliste ( 2019-09-02 15:05:15 +0300 )edit

@damien Calliste: that's great news. thank you for your work

rozgwi ( 2019-09-02 16:17:15 +0300 )edit

@Pekka Vuorela accepted the pull request today. It should be part of a coming version ;)

Damien Caliste ( 2019-09-10 14:48:01 +0300 )edit

Documents: Misaligned toolbar on Xperia X [released]

The question has been closed for the following reason "released in a software update" by rozgwi
close date 2019-12-15 21:12:58.782908

Comments

1 Answer

Comments

Question tools

Stats

Related questions

Documents: Misaligned toolbar on Xperia X [released]

The question has been closed for the following reason "released in a software update" by rozgwi close date 2019-12-15 21:12:58.782908

Comments

1 Answer

Comments

Question tools

Public thread

Stats

Related questions

The question has been closed for the following reason "released in a software update" by rozgwi
close date 2019-12-15 21:12:58.782908