[Feature-request] Conference call [released]

answered 2014-10-12 12:20:55 +0200

dtdmrr
311 ●2 ●5 ●5

updated 2014-10-12 12:22:00 +0200

Here's an updated patch for 1.0.8.xx. I also added labeled hangup buttons to give a little more control for killing a specific call. I suppose I should probably publish the patch in a more sustainable way. I was hoping someone would cleanup and add the functionality up stream, but that hasn't happened yet.

diff --git a/qml/pages/calling/InCallView.qml b/qml/pages/calling/InCallView.qml
index c4aa611..3fa3c41 100644
--- a/qml/pages/calling/InCallView.qml
+++ b/qml/pages/calling/InCallView.qml
@@ -1,6 +1,7 @@
 import QtQuick 2.0
 import Sailfish.Silica 1.0
 import Sailfish.Bluetooth 1.0
+import MeeGo.QOfono 0.2
 import "../../common/CallLog.js" as CallLog

 SilicaFlickable {
@@ -34,6 +35,14 @@ SilicaFlickable {
     opacity: enabled ? 1.0 : 0.0
     contentHeight: height

+    property string modemPath: ofonoManager.modems.length > 0 ? ofonoManager.modems[0] : ""
+
+    OfonoManager { id: ofonoManager }
+    OfonoVoiceCallManager {
+   id: voiceCallManager
+   modemPath: root.modemPath
+    }
+
     function reset() {
         telephony.audioMode = "earpiece"
         // passing true to hide() makes hiding immediate
@@ -105,6 +114,11 @@ SilicaFlickable {
             text: qsTrId("voicecall-me-add_call")
             onClicked: main.addCallMode = true
         }
+        MenuItem {
+            visible: telephony.voiceCalls.count > 1
+            text: "Merge Calls"
+            onClicked: voiceCallManager.createMultiparty()
+        }
         Repeater {
             model: telephony.voiceCalls
             delegate: MenuItem {
@@ -420,28 +434,42 @@ SilicaFlickable {
         }
     }

-    Button {
-        id: endCallButton
-        parent: inCallKeypad.open && !inCallKeypad.moving ? inCallKeypad : root.contentItem
-        text: {
-            if (main.state === 'dialing' || main.state == 'alerting')
-                qsTrId("voicecall-bt-cancel")
-            else if (main.state == 'null' || main.state == 'disconnected')  // Call has ended so preserve previous text to avoid flicker.
-                text
-            else
-                qsTrId("voicecall-bt-end_call")
-        }
-        width: Screen.width/2
-        height: Theme.itemSizeLarge
-        anchors {
-            bottom: parent.bottom
-            horizontalCenter: parent.horizontalCenter
-        }
-        onClicked: telephony.hangupCall(telephony.primaryCall)
-        enabled: main.state !== 'null' && main.state !== "silenced" && main.state !== "disconnected"
-        opacity: enabled ? 1.0 : 0.0
-        Behavior on opacity { FadeAnimation { } }
-    }
+   Column {
+       id: endCallButton
+       parent: inCallKeypad.open && !inCallKeypad.moving ? inCallKeypad : root.contentItem
+       width: Screen.width/2
+       spacing: Theme.paddingSmall
+       anchors {
+           bottom: parent.bottom
+           horizontalCenter: parent.horizontalCenter
+       }
+       Repeater {
+           model: telephony.voiceCalls
+           delegate: Button {
+               text: {
+                   if (instance == telephony.primaryCall
+                   && (main.state === 'dialing' || main.state == 'alerting'))
+                       qsTrId("voicecall-bt-cancel")
+                   else if (main.state == 'null' || main.state == 'disconnected')
+                   // Call has ended so preserve previous text to avoid flicker.
+                       text
+                   else
+                       qsTrId("voicecall-bt-end_call") + ": " + CallLog.callerNameShort(telephony.callerDetails[instance.handlerId].person, instance.lineId)
+   //telephony.primaryCall.lineId
+                     }
+               width: Screen.width/2
+               height: Theme.itemSizeLarge
+               anchors {
+                   //bottom: parent.bottom
+                   horizontalCenter: parent.horizontalCenter
+               }
+               onClicked: telephony.hangupCall(instance)
+               enabled: main.state !== 'null' && main.state !== "silenced" && main.state !== "disconnected"
+               opacity: enabled ? 1.0 : 0.0
+               Behavior on opacity { FadeAnimation { } }
+           }
+       }
+   }

     InCallKeypad {
         id: inCallKeypad

answered 2014-01-27 10:05:53 +0200

dtdmrr
311 ●2 ●5 ●5

Here's a patch to try. Apply it to /usr/share/voicecall-ui-jolla. It adds a "merge call" option to the pulldown menu when there are two or more calls connected. This is crude, and needs more for clean 3-way/multiparty calling.

Note: you should probably make sure to revert this before running system updates.

diff --git a/qml/pages/calling/InCallView.qml b/qml/pages/calling/InCallView.qml
index 4b7b822..27a659a 100644
--- a/qml/pages/calling/InCallView.qml
+++ b/qml/pages/calling/InCallView.qml
@@ -1,6 +1,7 @@
 import QtQuick 2.0
 import Sailfish.Silica 1.0
 import Sailfish.Bluetooth 1.0
+import MeeGo.QOfono 0.2
 import "../../common/CallLog.js" as CallLog

 SilicaFlickable {
@@ -29,6 +30,14 @@ SilicaFlickable {
     opacity: enabled ? 1.0 : 0.0
     contentHeight: height

+    property string modemPath: ofonoManager.modems.length > 0 ? ofonoManager.modems[0] : ""
+
+    OfonoManager { id: ofonoManager }
+    OfonoVoiceCallManager {
+   id: voiceCallManager
+        modemPath: root.modemPath
+    }
+
     function reset() {
         telephony.audioMode = "earpiece"
         // passing true to hide() makes hiding immediate
@@ -81,6 +90,11 @@ SilicaFlickable {
             text: qsTrId("voicecall-me-add_call")
             onClicked: main.addCallMode = true
         }
+        MenuItem {
+            visible: telephony.voiceCalls.count > 1
+            text: "Merge Calls"
+            onClicked: voiceCallManager.createMultiparty()
+        }
         Repeater {
             model: telephony.voiceCalls
             delegate: MenuItem {

answered 2015-03-09 12:32:59 +0200

Victorious
918 ●24 ●41 ●48

updated 2015-03-09 12:35:44 +0200

Made patch and now works a conference callThere solution !

answered 2015-01-13 12:16:02 +0200

rpnet100
31 ●2 ●2

Can anyone tell how to apply patch? please give steps when I tried showing access denied.

answered 2015-01-19 12:01:25 +0200

r0kk3rz
10112 ●108 ●186 ●181

@cybette

Sorry if this has already been a topic of a Mer Meeting, but is there a reason why this hasn't been done yet? It appears to be a straight forward case of implementing a UI for an existing Ofono feature. The fact that his has been hanging around for a year leads me to think its not that simple.

Could you find out for us?

answered 2016-12-26 14:03:40 +0200

DC
1646 ●34 ●54 ●53

I am on 2.0.5.6. I cant make another call while a ongoing call. Pully menu shows call option but doesnt work. Cant see option for add call for an incoming call.

Are these features absent in 2.0.5.6 or problem only with my phone?

answered 2015-01-14 16:12:47 +0200

Harrshad
41 ●1 ●2 ●6

updated 2015-01-18 18:02:38 +0200

Can anyone tell how to apply patch? #dtdmrr

answered 2015-07-05 10:25:55 +0200

kossu
11 ●2 ●2

The feature at the moment is that you can have multiple calls on at the same time and toggle between them, but you cannot yet have a conference call.