Bug: Notes app deletes different note than selected [released]

answered 2014-01-13 04:54:55 +0200

Tanghus
10524 ●85 ●118 ●125

https://github.com/tanghu...

updated 2014-01-13 04:55:35 +0200

I got caught by this in my kitchen timer app. The delete function uses the models index to select which note to delete, but if a remorse runs out the index is decremented leading to deletion of the wrong item.

From /usr/share/jolla-notes/qml/OverviewPage.qml

Currently the notes app does:

        function deleteNote() {
            var remorse = remorsecomponent.createObject(view)
            remorse.execute(noteitem, qsTrId("notes-la-deleting"),
                            function() {
                notesModel.deleteNote(index)
                remorse.destroy(1)
            })
        }

But it should cache the index:

        function deleteNote() {
            var remorse = remorsecomponent.createObject(view)
            var idx = index
            remorse.execute(noteitem, qsTrId("notes-la-deleting"),
                            function() {
                notesModel.deleteNote(idx)
                remorse.destroy(1)
            })
        }