We have moved to a new Sailfish OS Forum. Please start new discussions there.
1

Changes in colors codes (v3.0.0.8) - need some help (partially solved)

asked 2018-11-15 10:35:48 +0300

Schturman gravatar image

updated 2018-11-17 03:09:21 +0300

Hi to all.
I noticed about some changes in the colors on v3.0.0.8. And I can't fix some of my apps/patches, maybe here someone can help to fix it.
P.S. Already asked Andrey (Coderus), he can't help for now (lack of time).

  1. Look at this two pictures, one before and one after update. After update the image with buttons always white and text under slider also can't change itself.
    Colors error

Here is a code that slider use to change colors, but probably I need to change it somehow for v3.0.0.8, because it not do what it should to do.

color: customCameraOverlay.defaultbasel == 1 ? Color.toHighlight(Color.fromHsva(customCameraOverlay.baselcolor/100, 1.0, 0.5, 1.0)) : Qt.darker(Color.toHighlight(Color.fromHsva(customCameraOverlay.baselcolor/100, 1.0, 0.5, 1.0)))

And here the full code from this patch: https://pastebin.com/Uk4rbix7 (maybe some other lines should be changed instead this one).
Same color problems I have in two other apps like FastDial_icon and Fastmail_icon.

  1. The second question is why my icons not inverted like original when I choose the white themes ?
    My icons placed in the same location like original icons, and it also .png files.
    White icons

Will be nice if someone know how to fix it. Thanks.


UPDATE (17.11.2018):
The first question is solved (big thanks to @Ancelad) and I updated my package.
And yes, we have some changes in the slider code for example:

color: customCameraOverlay.defaultbasel == 1 ? Theme.highlightFromColor(Color.fromHsva(customCameraOverlay.baselcolor/100, 1.0, 0.5, 1.0), colorScheme) : Qt.darker(Theme.highlightFromColor(Color.fromHsva(customCameraOverlay.baselcolor/100, 1.0, 0.5, 1.0), colorScheme))

The second question is still not answered...

edit retag flag offensive close delete

Comments

You have a mixture of terms that may not be helping;' basel and bevel', the word is 'bevel'.....although, upon closer inspection, grammar shouldn't matter in this case, albeit, it's a little confusing as an 'onlooker'.

Spam Hunter ( 2018-11-15 13:12:01 +0300 )edit

@Edz, It's just mistyping. It should be bezel instead basel. but it's not a point at all. And it's not what cause to problem in my code.

Schturman ( 2018-11-15 13:18:18 +0300 )edit

I'm just viewing what I can while on tea break, I've amended my original comment reflecting your comments.

Spam Hunter ( 2018-11-15 13:20:33 +0300 )edit

2 Answers

Sort by » oldest newest most voted
0

answered 2018-11-15 14:02:22 +0300

AliN gravatar image

For the icons, you can have two dark and light icons for light/dark ambiences, respectively. You can see it on my patch for voice-call shortcut. Say the icon is named folder-settings in your codes, you can have two icons as:

folder-settings-dark.png (black colored)

folder-settings-light.png (white colored)

edit flag offensive delete publish link more

Comments

I'm still curious why white ambiences don't affect third-party icons. I thought there may be a theme cache file, but found nothing.

AliN ( 2018-11-15 14:06:28 +0300 )edit

Sure it possible to do diff icons, but like you answered to yourself, my question is still not answered… I don't understand why it not invert third-party icons even the icons in the same location and the same format (.png).

Schturman ( 2018-11-15 21:14:25 +0300 )edit
0

answered 2018-11-17 03:10:19 +0300

Schturman gravatar image

First question is solved (thanks to @Ancelad). I updated my first post.

edit flag offensive delete publish link more
Login/Signup to Answer

Question tools

Follow
2 followers

Stats

Asked: 2018-11-15 10:35:48 +0300

Seen: 405 times

Last updated: Nov 17 '18