Top menu shouldn't allow to organize when device is locked [released]
asked 2018-11-18 01:04:24 +0200
Currently, when device is locked, it's not possible to use connectivity switches from the lock screen top menu; but it is possible to organize (re-order/remove) top menu items. It shouldn't be either.
Edit: I'm not speaking about toggles/switches, just mentioned them as an example. I'm talking about organize. It shouldn't be enabled when device is locked, or at least there should be an option. The current behavior (always enabled even on device lock seems a security flaw to me.) It's easy with few changes in:
/usr/share/lipstick-jolla-home-qt5/topmenu/TopMenu.qml
@@ -5,6 +5,7 @@
import com.jolla.lipstick 0.1
import org.freedesktop.contextkit 1.0
import org.nemomobile.configuration 1.0
+import org.nemomobile.devicelock 1.0
SilicaFlickable {
id: topMenu
@@ -311,6 +312,7 @@
MenuItem {
//% "Organize"
text: qsTrId("lipstick_jolla_home-me-topmenu_organize")
+ enabled: Desktop.deviceLockState == DeviceLock.Unlocked
onClicked: Lipstick.compositor.topMenuLayer.housekeeping = !Lipstick.compositor.topMenuLayer.housekeeping
}
Source: this patch of mine.
The brightness and ringtone sliders can also be used. The only valid use cases are the use of the flashlight or the camera so you can activate it real quick. But even the use of the camera when the phone is locked is arguable so it needs to be configurable. I think the topmenu shouldn't be available when the phone is locked.
rgrnetalk ( 2018-11-18 09:48:39 +0200 )editI have a similar question here: https://together.jolla.com/question/193459/allow-top-menu-shortcuts-toggling-on-locked-device/ - but I disagree about connectivity switches. I would like to use them even if the device is locked. Organising menu items I don't want to be accesible. So I think the security settings should be configurable.
naytsyrhc ( 2018-11-18 13:05:36 +0200 )edit@rgrnetalk the camera issue was discussed a lot before. The outcome is the quick camera gesture by swipe from bottom also available on locked device. So I think that security setting should also set if camera may be accessed from shortcuts in top menu. However as mentioned before, I want to have also network toggles accessible and not only flashlight.
naytsyrhc ( 2018-11-18 13:10:33 +0200 )editI voted up! Definitely need some rework.
Jk ( 2018-11-18 16:12:37 +0200 )editI just checked behaviour again. Even flight-mode toggle is locked with locked device. I totally disagree with above opinion and try to emphasize a configurable locking behaviour or strongly recommend my question (see above).
naytsyrhc ( 2018-11-18 17:11:49 +0200 )edit