[feature request] add a check: do not install update if patches are enabled

asked 2015-05-06 10:02:24 +0200

c.la gravatar image

updated 2015-05-06 10:02:50 +0200

as the title says, please add a check in the update script such as if it detects enabled patches the update doesn't start. This should also apply to all the incompatible apps (like phonehook for 1.1.4.29).

There have been quite a few threads about bricked jolla because of these incompatibilities, just to report a few:

https://together.jolla.com/question/91260/help-11429-almost-bricked-my-device/

https://together.jolla.com/question/91886/114-bricked-phone/

thank you

edit retag flag offensive close delete

Comments

Impossible to implement perfectly, would be a feature sometimes working and sometimes not. The nightmare of a software.

William ( 2015-05-06 10:06:18 +0200 )edit

Is it possible to deactivate patches from Jolla side somehow? Could there be an on/off switch integrated into Patchmanager that Jolla could trigger during update start?

PatsJolla ( 2015-05-06 16:44:34 +0200 )edit

Patchmanager daemon does have a --unapply-all option. I am sure that can be called if patchmanager is installed. I am not sure how well it works though.

patchmanager-daemon

Usage:
  patchmanager-daemon               : run as daemon
  patchmanager-daemon -a <patch>    : apply a patch
  patchmanager-daemon -u <patch>    : unapply a patch
  patchmanager-daemon --unapply-all : unapply all patches
AbyZThomas ( 2015-05-06 19:50:54 +0200 )edit

@William Why? Just get in tiouch to the patchmanager devs and have them implement an interface that does not change over time and lets jolla disable and enable all patches. I don't think is so impossible to achieve.

c.la ( 2015-05-12 09:30:40 +0200 )edit

@c.la Patchmanager is not a noted app by Jolla (considering any quality issues, etc), it is not in the official store. In this case Jolla would rely with their update on a software they have "nothing to do with". And why could one only install patches with patchmanager? Options are endless... Therefore for Jolla it is impossible to make such a tool working for all the cases (and it gets really messy when we are talking about patches), but someone else of course could easily make an app on OpenRepos, which could do this before and after update for patchmanager specifically. Such an app would be nice of course, but it will never happen through Jolla I guess.

They can add a general warning about patches on the update release notes. But one should be at least minimally aware of what a patch is doing, so the warning is kind of evident.

William ( 2015-05-12 10:57:37 +0200 )edit