Display contact number in call history

answered 2014-01-08 23:38:30 +0300

chemist
41469 ●392 ●542 ●615

moderator

http://talk.maemo.org/

updated 2014-10-28 14:21:52 +0300

I now happen to have all four entries of a single contact on my history and yes I just called the wrong number from it... went to people... this is nothing like useful at all! Call history in phone is therefor broken for good!

Merge them and show a list to dial from, ordered by last used - add settings.

After unlocking this newly introduced in 1.0.3.8 feature from Settings->Apps->Phone I had the impression that someone thought that linking the history item to the contact is a good pretty fast solution.

There is something gone completely wrong... with 1.0.3.8 you get fwd to the contact-card but still do not see which number was called from as it highlights the first number instead of the one from the history.

Unsaved numbers do open a contact-card too... well that saves the long-tap the save to contact which is missing when deactivating the quick call.

1.0.7.16 introduced the Personal/Work indication, which does not help a thing if not setup on all accounts & still nothing to actually see which number it is :/

Update: now we see Personal or Work both are nice but still I have no clue what number it is, my GF for example has 3 entries as Personal, my sister two, another friend 3 again and so on. I just changed some entries to None to see if the type shows, no, it does not.

Solution

A solution would be to leave the quick-dial-toggle as is but add the number below the contact with designated type

John Doe
  Home +1234567890

Unknown numbers should not have the fwding to a contact-card if quickdial is deactivated. For save as contact this bug is still valid

answered 2014-04-02 15:06:10 +0300

roboro
1558 ●8 ●14 ●15

Okay folks... this is a complete hack... but it at least provides some immediate relief if you want to be able to see numbers next to your contact names in the call-log.

I opened up /usr/share/voicecall-ui-jolla/qml/pages/calllog/CallLogItem.qml in an editor. Inside the 'Row' element, I edited the Labels slightly... so now I have:

Label {
        id: firstNameText
        opacity: privateNumber ? 0.5 : 1.0
        text: people.populated || remoteUid !== undefined
                  ? (!person || (person.primaryName.length === 0 && person.secondaryName.length === 0)
                         ? main.formatNumber(remoteUid)
                         : person.primaryName)
                  : ""
        color: highlighted ? Theme.highlightColor : primaryColor
        truncationMode: TruncationMode.Fade
        width: Math.min(implicitWidth, parent.width)
    }
Label {
        id: secondaryNameText
        text: people.populated && person ? person.secondaryName : ""
        color: highlighted ? Theme.secondaryHighlightColor : secondaryColor
        truncationMode: TruncationMode.Fade
        width: Math.min(implicitWidth, parent.width - firstNameText.width)
        visible: width > 0
    }

Label {
        text: people.populated && person ? "("+main.formatNumber(remoteUid)+")": ""
        color: highlighted ? Theme.highlightColor : primaryColor
        font.pixelSize: Theme.fontSizeExtraSmall
        truncationMode: TruncationMode.Fade
        width: Math.min(implicitWidth, parent.width - firstNameText.width - secondaryNameText.width)
        visible: width > 0
    }

Its not the very best solution around... but at least it gives you something to work with for now. The glory of open-source software is that you can at least implement quick fixes like this...

I realize that this is a 'Jolla' system file... so if you mess this up, you may find that your phone doesn't work so well. So, backup that file before you muck with it. Also, you need root privileges to write to this file... so devel-su

I found that the phone required a reboot before this change became active... I'm not sure why, but maybe the voicecall-ui is preloaded or something.

This works fine for me! Hopefully it will make someone else's day.

answered 2014-04-02 21:16:37 +0300

This post is a wiki. Anyone with karma >75 is welcome to improve it.

updated 2014-04-11 13:58:43 +0300

roboro
1558 ●8 ●14 ●15

Right, I've replaced the full file with a diff that can be used to patch the original file. I've also incorporated a fix to have the number appear below the name. The diff follows:

--- CallLogItem.qml 2014-04-11 10:06:47.668188992 +0100
+++ CallLogItem-ro.qml      2014-04-11 11:43:22.981023867 +0100
@@ -38,27 +38,55 @@
         }

         spacing: Theme.paddingSmall
-
-        Label {
-            id: firstNameText
-            opacity: privateNumber ? 0.5 : 1.0
-            text: people.populated || remoteUid !== undefined
+        Item {
+            id: nameItem
+            width: parent.width
+
+            Label {
+                id: firstNameText
+                anchors {
+                    left: parent.left;
+                    verticalCenter: parent.verticalCenter
+                }
+                opacity: privateNumber ? 0.5 : 1.0
+                text: people.populated || remoteUid !== undefined
                       ? (!person || (person.primaryName.length === 0 && person.secondaryName.length === 0)
                              ? main.formatNumber(remoteUid)
-                             : person.primaryName)
+                             : person.primaryName+" ")
                       : ""
+                color: highlighted ? Theme.highlightColor : primaryColor
+                truncationMode: TruncationMode.Fade
+                width: Math.min(implicitWidth, parent.width)
+            }
+            Label {
+                id: secondaryNameText
+                anchors {
+                    left: firstNameText.right;
+                    verticalCenter: parent.verticalCenter;
+                } 
+                text: people.populated && person ? person.secondaryName : ""
+                color: highlighted ? Theme.secondaryHighlightColor : secondaryColor
+                truncationMode: TruncationMode.Fade
+                width: Math.min(implicitWidth, parent.width - firstNameText.width)
+                visible: width > 0
+            }
+            
+            Label {
+                text: people.populated && person ? main.formatNumber(remoteUid): ""
+                anchors {
+                    left: parent.left;
+                    top: firstNameText.bottom;
+                    verticalCenter: parent.verticalCenter;
+                }
+                color: highlighted ? Theme.highlightColor : primaryColor
+                font.pixelSize: Theme.fontSizeExtraSmall
+                truncationMode: TruncationMode.Fade
+                width: Math.min(implicitWidth, parent.width)
+                visible: width > 0
+            }

-            color: highlighted ? Theme.highlightColor : primaryColor
-            truncationMode: TruncationMode.Fade
-            width: Math.min(implicitWidth, parent.width)
-        }
-        Label {
-            text: people.populated && person ? person.secondaryName : ""
-            color: highlighted ? Theme.secondaryHighlightColor : secondaryColor
-            truncationMode: TruncationMode.Fade
-            width: Math.min(implicitWidth, parent.width - firstNameText.width)
-            visible: width > 0
         }
+
     }

     Column {

To incorporate this fix, you can copy the content of the patch above, and save it to /usr/share/voicecall-ui-jolla/qml/pages/calllog/CallLogItem.patch

Backup your original CallLogItem.qml file. I just copied it to CallLogItem.qml.orig:

cp CallLogItem.qml CallLogItem.qml.orig

Make sure you have 'patch' installed:

pkcon install patch

In /usr/share/voicecall-ui-jolla/qml/pages/calllog/ run:

patch < CallLogItem.patch

To see the change without having to reboot your phone, run the following as the nemo user:

systemctl --user restart voicecall-ui-prestart.service

Reopen your calllog and check that everything looks okay. If not... revert to the original Jolla CallLogItem.qml file.

answered 2014-09-27 22:15:00 +0300

baptx
638 ●13 ●22 ●23

https://drawcode.eu/

updated 2015-01-11 22:40:51 +0300

Thanks community for sharing some locations of Jolla's system apps, hopefully the UI is open source and in QML so you don't need to compile modifications.

I think that we need to see the phone number in SMS conversations, call history and incoming calls and not just show a contact name or indication like "Personal"/"Work"/"Other". When you have a contact with several numbers, you need to know the phone number and sometimes you don't even have an indication shown because you didn't save a number as "Personal" or "Work".

Below are the small modifications I made to display the contact phone number. I'm sharing the diffs with original files (diff -u original_file.qml.bak modified_file.qml) so you can use command "patch < patch_name.patch" for the current update 1.0.8.19 but files may change in future updates and you'll need to adapt changes. Be sure to keep a backup of modified files in the same directory like original_file.qml.bak and follow these steps only if you know what you are doing. It should not be you doing the changes but Jolla allowing you to choose what details you want to see in future updates.

For SMS conversations:

File /usr/share/jolla-messages/pages/conversation/SMSMessageDelegate.qml in label id "timestamp" after var re = Format.formatDate(modelData.startTime, Formatter.Timepoint).

--- /usr/share/jolla-messages/pages/conversation/SMSMessageDelegate.qml.bak 2014-09-25 18:19:46.145971935 +0200
+++ /usr/share/jolla-messages/pages/conversation/SMSMessageDelegate.qml 2014-09-27 20:05:30.234271645 +0200
@@ -151,6 +151,7 @@
                 return qsTrId("messages-message_state_waiting")
             } else {
                 var re = Format.formatDate(modelData.startTime, Formatter.Timepoint)
+       re += " | " + remoteUid
                 if (modelData.status === CommHistory.DeliveredStatus) {
                     //% "Delivered"
                     re += " | " + qsTrId("messages-message_state_delivered")

For call history (used by outgoing/ongoing call too):

File /usr/share/voicecall-ui-jolla/qml/pages/calllog/CallLogItem.qml you can replace numberDetail (it means "Personal"/"Work" indications) with the phone number (remoteUid).

--- /usr/share/voicecall-ui-jolla/qml/pages/calllog/CallLogItem.qml.bak 2014-09-27 15:21:25.593200743 +0200
+++ /usr/share/voicecall-ui-jolla/qml/pages/calllog/CallLogItem.qml 2014-09-27 16:06:27.116727246 +0200
@@ -113,7 +113,7 @@
             right: description.right
         }
         font.pixelSize: Theme.fontSizeExtraSmall
-        text: numberDetail + (numberDetail.length && connectionDetail.length ? " | " : "") + connectionDetail
+        text: person ? remoteUid : "" + (numberDetail.length && connectionDetail.length ? " | " : "") + connectionDetail
         color: highlighted ? Theme.secondaryHighlightColor : secondaryColor
     }

For incoming calls:

File /usr/share/voicecall-ui-jolla/qml/pages/calling/IncomingCallView.qml at the end of "secondText" information.

--- /usr/share/voicecall-ui-jolla/qml/pages/calling/IncomingCallView.qml.bak    2014-09-27 16:13:33.689421940 +0200
+++ /usr/share/voicecall-ui-jolla/qml/pages/calling/IncomingCallView.qml    2014-09-27 16:35:11.865418294 +0200
@@ -55,7 +55,7 @@
     active: telephony.incomingCallerDetails ? !telephony.incomingCallerDetails.silenced : false
     phoneNumber: remoteUid
     firstText: person ? person.primaryName : ""
-    secondText: person ? person.secondaryName : ""
+    secondText: person ? person.secondaryName + remoteUid : remoteUid
     callWaiting: (telephony.incomingCall && telephony.primaryCall) ||
                  (telephony.primaryCall && telephony.heldCall && telephony.primaryCall !== telephony.heldCall)
     callCount: telephony.voiceCalls.count

In the future, it would be great if Jolla users can choose what they want to see without modifying source code. But I think we should be able to see the phone number by default next to each message/call in SMS conversations, call history and incoming calls.

Possible duplicate: https://together.jolla.com/question/17830/ui-display-recipientsender-phone-type-in-smscall-history-view/

Update: With SailfishOS update 10 (1.1.1.27), SMSMessageDelegate.qml has not changed so you can apply patch without problem to /usr/share/jolla-messages/pages/conversation/SMSMessageDelegate.qml CallLogItem.qml and IncomingCallView.qml have been moved and got some modifications but patches are still working, you can use them on /usr/share/voicecall-ui-jolla/pages/calllog/CallLogItem.qml and /usr/share/voicecall-ui-jolla/pages/calling/IncomingCallView.qml (files are not in qml folder anymore)

answered 2014-06-11 12:52:55 +0300

velimir
103 ●9 ●7

updated 2014-06-11 13:01:50 +0300

Here is a quick modification i put together (for the new update: 1.0.7.16, Saapunki). IMHO looks better this way, plus you have the number displayed too.

--- CallLogItem.qml     2014-06-11 10:57:14.643409228 +0200                                                                                              
+++ CallLogItem.qml_mod 2014-06-11 11:49:10.395167585 +0200
@@ -78,7 +78,7 @@
                 width: Math.min(implicitWidth, parent.width)
             }
             Label {
-                text: people.populated && person ? person.secondaryName : ""
+                text: people.populated && person ? " " + person.secondaryName : ""
                 color: highlighted ? Theme.secondaryHighlightColor : secondaryColor
                 truncationMode: TruncationMode.Fade
                 width: Math.min(implicitWidth, parent.width - firstNameText.width)
@@ -104,16 +104,27 @@
             }
         }
     }
-
     Label {
+       opacity: 0.8
         anchors {
             top: description.bottom
-            right: description.right
+            left: contactNumber.right
         }
         font.pixelSize: Theme.fontSizeExtraSmall
-        text: numberDetail + (numberDetail.length && connectionDetail.length ? " | " : "") + connectionDetail
+        text: " " + numberDetail + (numberDetail.length && connectionDetail.length ? " | " : "") + connectionDetail
         color: highlighted ? Theme.secondaryHighlightColor : secondaryColor
     }
+    Label {
+       id: contactNumber
+       opacity: 0.8
+        anchors {
+            top: description.bottom
+            left: description.left
+        }
+        font.pixelSize: Theme.fontSizeExtraSmall
+        text: (numberDetail.length && connectionDetail.length ? " | " : "") + main.formatNumber(remoteUid)
+        color: highlighted ? Theme.secondaryHighlightColor : primaryColor
+    }

answered 2014-07-15 13:22:20 +0300

velimir
103 ●9 ●7

updated 2014-07-16 10:42:39 +0300

Hi, here is the new version. Code is different but you get the same result..

--- CallLogItem.qml     2014-07-15 12:13:40.301305020 +0200
+++ /usr/share/voicecall-ui-jolla/qml/pages/calllog/CallLogItem.qml     2014-07-15 12:12:35.131764359 +0200
@@ -110,12 +110,23 @@ ListItem {
     Label {
         anchors {
             top: description.bottom
-            right: description.right
+            left: phoneNumber.right
         }
         font.pixelSize: Theme.fontSizeExtraSmall
-        text: numberDetail + (numberDetail.length && connectionDetail.length ? " | " : "") + connectionDetail
+        text: " " + numberDetail + (numberDetail.length && connectionDetail.length ? " | " : "") + connectionDetail
         color: highlighted ? Theme.secondaryHighlightColor : secondaryColor
     }
+    
+    Label {
+       id: phoneNumber
+        anchors {
+            top: description.bottom
+            left: description.left
+        }
+        font.pixelSize: Theme.fontSizeExtraSmall
+        text: person ? CallLog.formatNumber(remoteUid) : " "
+        color: highlighted ? Theme.secondaryHighlightColor : primaryColor 
+    }

     Image {
         id: icon

answered 2015-05-18 19:06:59 +0300

femtopeta
1406 ●20 ●30 ●34

http://reinblau.de/

updated 2015-05-18 20:38:36 +0300

Display absolute time in call history

Sorry for hijacking this thread, but here are the qml-cracks - and it is also about modifying CallLogItem.qml.

I really would like to have absolute Date/Time in callog. Its nice to know somebody called "yesterday", but sometimes (no, in general: always) I would like to know the time.

There is already #63468, but its a different approach.

The formatting parameter is in line 88, namely "TimepointRelativeCurrentDay". Is there any chance to have DD.MM.YYYY-HH:MM here? If I replace

text: { Qt.application.active, Format.formatDate(time, Formatter.TimepointRelativeCurrentDay) }

with

text: { Qt.application.active, Format.formatDate(time, "ddd dd.MM hh:mm") }

it works somehow. It apparently breaks the formatting and gives the default locale, which in my case is hh:mm DD/MM/YYYY. That does the trick - but its not nice ;)

(edit: bad hack solution)

answered 2017-10-19 20:55:34 +0300

poddl
5982 ●65 ●93 ●94

http://www.edor.de/

updated 2017-10-19 20:57:10 +0300

..

The phone call history only display contacts name and it's not possible to know the number. A single tap on the contact name make a call but i still don't know which number I’m calling. Long tap shows several options like call duration but still no phone number. Did i miss something?

Yes you do miss something: Long tap on the name shows the number and the call duration, this is already since about 6 month or 1 year the case. Selecting "open contact" you will see at the bottom the call history of all calls to this contact

more handy: settings -> Apps -> Phone, disable the "direct call or shortcut call" i don't know how is the name in english, after disabled this setting, you can tap the entry in the call history and you reach direct the contact card. At the end, all calls with number and phone type are accessible. Last option on contact card. long tap still works in the contact list.

Does this provide what you did miss?

answered 2014-12-25 21:11:02 +0300

Schturman
5645 ●143 ●216 ●232

velimir , Can you update your patch please ? New sys update (1.1.1.27) and new patch needed :)

Thanks